This repository was archived by the owner on May 22, 2025. It is now read-only.
NT IRN app tweaks, bugfixes and code refactor - #20421
Merged
Merged
Conversation
Yogbot-13
added
Fix
ShoziOffical
changed the title
Contributor
|
the word "Budget ordering" makes me think you are using a discounted service, or ordering the worse versions of gear, rather than using a departmental budget |
Contributor
Author
how about "departmental purchasing", i think this is more suitable |
Moltijoe
approved these changes
Sep 29, 2023
Chubbygummibear
approved these changes
Sep 30, 2023
Chubbygummibear
left a comment
Chubbygummibear
left a comment
Contributor
There was a problem hiding this comment.
TGUI looks fine, the linter isn't throwing a fit, and the addition of the video demo gives me confidence in its functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
Add an option to toggle between using departmental budget or cargo budget when requesting a package
Using department budget to order now actually show the departmental name to avoid confusion
Fixes issue when departmental budget amount not appearing on the app
Fixes NT IRN app not printing requisition paper
Fixes modular computer's NT IRN app showing buyer as unknown because it doesnt recognize the pda
Refactored code a bit
private crate can now be sent back to CC if unlocked
Why is this good for the game?
Having it as a toggle allows you to conveniently order things without affecting the departmental budget or cargo budget. Currently, switching budgets requires removing the ID, which is inconvenient.
Testing
tested on local, results:
Changelog
🆑
tweak: Add an option to toggle between using departmental budget or cargo budget when requesting a package
tweak: Using department budget to order now actually show the departmental name to avoid confusion
bugfix: Fixes issue when departmental budget amount not appearing on the app
bugfix: Fixes NT IRN app not printing requisition paper
bugfix: Fixes modular computer's NT IRN app showing buyer as unknown because it doesnt recognize the pda
tweak: Refactored code a bit
tweak: private crate can now be sent back to CC if unlocked
/:cl: